Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert dep changes in #5651 #5711

Merged
merged 1 commit into from
Jul 13, 2018

Commits on Jul 13, 2018

  1. Partially revert dep changes in rust-lang#5651

    Some logic which was tweaked around the dependencies of build script targets was
    tweaked slightly in a way that causes cargo to stack overflow by accientally
    adding a dependency loop. This commit implements one of the strategies discussed
    in rust-lang#5711 to fix this situation.
    
    The problem here is that when calculating the deps of a build script we need the
    build scripts of *other* packages, but the exact profile is somewhat difficult
    to guess at the moment we're generating our build script unit. To solve this the
    dependencies towards other build scripts' executions is added in a different
    pass after all other units have been assembled. At this point we should know for
    sure that all build script executions are in the dependency graph, and we just
    need to add a few more edges.
    
    Closes rust-lang#5708
    alexcrichton committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    f9d4927 View commit details
    Browse the repository at this point in the history