Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doctests linking too many libs. #5651

Merged
merged 5 commits into from
Jul 5, 2018
Merged

Commits on Jun 26, 2018

  1. Fix doctests linking too many libs.

    Fixes rust-lang#5650.  cc rust-lang#5435
    
    As part of my recent work on profiles, I introduced some situations where a
    library can be compiled multiple times with different settings.  Doctests were
    greedily grabbing all dependencies for a package, regardless of which target
    is was for.  This can cause doctests to fail if it links multiple copies of
    the same library.
    
    One way to trigger this is `cargo test --release` if you have dependencies, a
    build script, and `panic="abort"`.  There are other (more obscure) ways to
    trigger it with profile overrides.
    ehuss committed Jun 26, 2018
    Configuration menu
    Copy the full SHA
    00d325d View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2018

  1. Don't pollute the deps_map.

    In rare cases, the profile_for is set incorrectly for this temporary unit used
    to compute dependencies.  However, it's not needed since the RunCustomBuild
    Unit's parent is already in the map.
    ehuss committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    33a5f7c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    849220e View commit details
    Browse the repository at this point in the history
  3. Doctest cleanup.

    - Consolidate logic for determining doctest dependencies.
    - Use a struct for the doctest info in `Compilation`.
    ehuss committed Jun 27, 2018
    Configuration menu
    Copy the full SHA
    812fba6 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2018

  1. Configuration menu
    Copy the full SHA
    478d1ce View commit details
    Browse the repository at this point in the history