Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize integration tests as one crate with many modules. Issue #4867. Rebased V3 #5063

Merged
merged 3 commits into from
Feb 21, 2018

Conversation

Eh2406
Copy link
Contributor

@Eh2406 Eh2406 commented Feb 21, 2018

This is an automatic rebase of @rochamatcomp's work in #5022, as requested in #5038.

I take no credit for the changes; I just wanted faster test for my work. :-)

@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@Eh2406
Copy link
Contributor Author

Eh2406 commented Feb 21, 2018

We are green!

@matklad
Copy link
Member

matklad commented Feb 21, 2018

Excellent!

Thanks a lot @rochamatcomp for all the work and especially for the benchmarks, and @Eh2406 for the rebase!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 21, 2018

📌 Commit 7a56457 has been approved by matklad

@bors
Copy link
Contributor

bors commented Feb 21, 2018

⌛ Testing commit 7a56457 with merge 847f1f7...

bors added a commit that referenced this pull request Feb 21, 2018
Reorganize integration tests as one crate with many modules. Issue #4867. Rebased V3

This is an automatic rebase of @rochamatcomp's work in #5022, as requested in [#5038](#5038 (comment)).

I take no credit for the changes; I just wanted faster test for my work. :-)
@bors
Copy link
Contributor

bors commented Feb 21, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing 847f1f7 to master...

@Eh2406
Copy link
Contributor Author

Eh2406 commented Feb 22, 2018

looks like the automatic rebase missed the rename_deps tests, sorry. P.R. incoming.

Eh2406 added a commit to Eh2406/cargo that referenced this pull request Feb 22, 2018
bors added a commit that referenced this pull request Feb 22, 2018
fix a missing test, this was missed in the rebase of #5063

3 test did not get moved. in #5063.
@ehuss ehuss added this to the 1.26.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants