Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a token as parameter for publish, yank, owner. #4668

Closed
wants to merge 1 commit into from

Conversation

fa7ca7
Copy link
Contributor

@fa7ca7 fa7ca7 commented Oct 27, 2017

It's a proposal according to #4645.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@lukaslueg
Copy link
Contributor

Can't one override the token from .cargo/config with --token ? That might be a legitimate use case.

@alexcrichton
Copy link
Member

Thanks for the PR! This is, however, a breaking change, so I don't think we can land this as-is? Why wouldn't we want the ability to override as well?

@fa7ca7
Copy link
Contributor Author

fa7ca7 commented Oct 31, 2017

Probably it'd be better to implement local .cargo/credentials as discussed in #3978 (at the end of thread)?
For user it might look like:

$ cargo login token  # save to .cargo/credentials
$ cargo login --global token  # save to $HOME/.cargo/credentials

@alexcrichton
Copy link
Member

Perhaps? That's not something we probably want to decide here on this PR

@fa7ca7
Copy link
Contributor Author

fa7ca7 commented Oct 31, 2017

Ok, I closed this PR and modified the related issue. Looking forward to your feedback. Thank you

@fa7ca7 fa7ca7 closed this Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants