Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src/doc/manifest] Add section on Migrating to gitignore-like pattern matching #4298

Merged
merged 1 commit into from
Jul 19, 2017

Conversation

behnam
Copy link
Contributor

@behnam behnam commented Jul 18, 2017

Tracking issue: #4268

@behnam
Copy link
Contributor Author

behnam commented Jul 18, 2017

I have not seen any similar notices on http://doc.crates.io/ which made me wonder if this is the right place to notify the change, which will eventually update this part of the document.

What do you think, @alexcrichton, others?

### Migrating to `gitignore`-like pattern matching

The current interpretation of these configs is based on UNIX Globs, as
implemented in the [`glob` crate](https://crates.io/crates/glob). Cargo We want
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray "Cargo" here on this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Fixed!

@alexcrichton
Copy link
Member

Looks great!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 19, 2017

📌 Commit 69c74aa has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jul 19, 2017

⌛ Testing commit 69c74aa with merge 6708d70...

bors added a commit that referenced this pull request Jul 19, 2017
[src/doc/manifest] Add section on Migrating to `gitignore`-like pattern matching

Tracking issue: #4268
@bors
Copy link
Contributor

bors commented Jul 19, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6708d70 to master...

@bors bors merged commit 69c74aa into rust-lang:master Jul 19, 2017
@ehuss ehuss added this to the 1.21.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants