-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add android build support #3885
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
There is some interest on using rust on android (termux/termux-packages#261). rustup already has android build support. Even if cargo is being build with rust, I think it is good to have a docker image to build cargo. What about the travis android build? Should I remove it? |
☔ The latest upstream changes (presumably #3878) made this pull request unmergeable. Please resolve the merge conflicts. |
Thanks for the PR! Note though that the builds in this repository are going to be retired very soon. We're not actually making releases based on these builds any more right now, so these artifacts will just get gc'd at some point. It looks like no code changes happened here though? In that case I'd be ok to add a builder to verify that we can keep compiling for android, but otherwise maybe we should hold off until a PR can be made to rust-lang/rust? |
There is no code change.
Verify that cargo can be compiled for android (before rust-lang/rust/ is updated) is a good thing. I made a PR to add android host builders: rust-lang/rust#41149. |
Ok, perhaps we can pare this down to just one Android target? I suspect we won't need to test all android targets in full before changes reach rust-lang/rust |
3f9a269
to
4eab822
Compare
That's makes sense. I update the PR. |
@bors: r+ Thanks! |
📌 Commit f723268 has been approved by |
Add android build support This add android build support, including openssl.
☀️ Test successful - status-appveyor, status-travis |
This add android build support, including openssl.