From 2490f3fb6386aef30f197cb9dc82de3338bb8cac Mon Sep 17 00:00:00 2001 From: "Carol (Nichols || Goulding)" Date: Mon, 12 Sep 2016 22:26:16 -0400 Subject: [PATCH] Should not have to specify crates-io registry URL to replace-with Since cargo knows crates-io's registry URL and, anyway, you're trying to say that you don't want to use crates-io. --- src/cargo/sources/config.rs | 3 +++ tests/local-registry.rs | 48 +++++++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+) diff --git a/src/cargo/sources/config.rs b/src/cargo/sources/config.rs index e40b6a7d546..01205ff51b7 100644 --- a/src/cargo/sources/config.rs +++ b/src/cargo/sources/config.rs @@ -146,6 +146,9 @@ a lock file compatible with `{orig}` cannot be generated in this situation path.push(s); srcs.push(try!(SourceId::for_directory(&path))); } + if name == "crates-io" && srcs.is_empty() { + srcs.push(try!(SourceId::crates_io(self.config))); + } let mut srcs = srcs.into_iter(); let src = try!(srcs.next().chain_error(|| { diff --git a/tests/local-registry.rs b/tests/local-registry.rs index b974f01c4c8..7643a92aa57 100644 --- a/tests/local-registry.rs +++ b/tests/local-registry.rs @@ -348,3 +348,51 @@ unable to verify that `foo v0.0.1` is the same as when the lockfile was generate ")); } + +#[test] +fn crates_io_registry_url_is_optional() { + let root = paths::root(); + t!(fs::create_dir(&root.join(".cargo"))); + t!(t!(File::create(root.join(".cargo/config"))).write_all(br#" + [source.crates-io] + replace-with = 'my-awesome-local-registry' + + [source.my-awesome-local-registry] + local-registry = 'registry' + "#)); + + Package::new("foo", "0.0.1") + .local(true) + .file("src/lib.rs", "pub fn foo() {}") + .publish(); + + let p = project("bar") + .file("Cargo.toml", r#" + [project] + name = "bar" + version = "0.0.1" + authors = [] + + [dependencies] + foo = "0.0.1" + "#) + .file("src/lib.rs", r#" + extern crate foo; + pub fn bar() { + foo::foo(); + } + "#); + + assert_that(p.cargo_process("build"), + execs().with_status(0).with_stderr(&format!("\ +[UNPACKING] foo v0.0.1 ([..]) +[COMPILING] foo v0.0.1 +[COMPILING] bar v0.0.1 ({dir}) +[FINISHED] [..] +", + dir = p.url()))); + assert_that(p.cargo("build"), execs().with_status(0).with_stderr("\ +[FINISHED] [..] +")); + assert_that(p.cargo("test"), execs().with_status(0)); +}