Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only compile activated optional dependencies #1812

Merged
merged 2 commits into from
Jul 17, 2015
Merged

Only compile activated optional dependencies #1812

merged 2 commits into from
Jul 17, 2015

Commits on Jul 17, 2015

  1. Remove an unnecessary HashMap when Vec works 

    Dependencies aren't necessarily unique per name as the same dependency can show
up multiple times in various dependency kind lists, so it's not quite right to
use a hash map anyway.
    @alexcrichton
    alexcrichton committed Jul 17, 2015
    Configuration menu
    Copy the full SHA
    25644b7 View commit details
    Browse the repository at this point in the history

  2. Only compile activated optional dependencies 

    Development dependencies are traversed during the resolution process, causing
them to be returned as the list of dependencies for a package in terms of
resolution. The compilation phase would then filter these out depending on the
dependency's transitivity, but this was incorrectly accounted for when the
dependency showed up multiple times in a few lists.

This commit fixes this behavior by updating the filtering logic to ensure that
only activated optional dependencies (those whose feature names are listed) are
compiled.

Closes rust-lang#1805
    @alexcrichton
    alexcrichton committed Jul 17, 2015
    Configuration menu
    Copy the full SHA
    70152d8 View commit details
    Browse the repository at this point in the history