Teach publish the --dry-run flag
#1699
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| try!(config.shell().status("Uploading", pkg.package_id().to_string())); | ||
| try!(transmit(&pkg, &tarball, &mut registry)); | ||
| if !dry { |
There was a problem hiding this comment.
Could this check be pushed into the transmit function actually? There's a few more errors that can happen right before the publish and it'd be nice to catch those.
|
Nice! Could you also add a test for this option? |
Catch a few more errors by aborting midway through transmit().
|
I've moved the check into Ignoring the issue of checking whether or not the upload actually occurred, the tests I've written cover:
|
|
Those tests sound good to me! You maybe able to configure a host that's something like |
|
It seems that this has stalled, so I'm going to close this, but feel free to reopen with a test added! |
|
@JustAPerson: Any chance you could revive this? I just was thinking how wonderful this feature would be to verify a package is actually publishable before it's tagged with the release version. |
|
@erickt, |
|
@JustAPerson: No worries, I know what that's like. @alexcrichton keeps closing my rust PRs because I haven't had time to get them over the finish line yet :) |
Add --dry-run to cargo publish This PR picks up where @JustAPerson left off in #1699. I've updated their changes to apply to current master and added tests, including (I think) a test that checks that the upload doesn't actually occur. The output is as it was before:  Closes #1332
Closes #1332
Open to feedback on rewording messages and such. I tried to follow this precedent for erroring on conflicting flags.