Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(resolver): Lay groundwork for documenting MSRV-aware logic #14662
docs(resolver): Lay groundwork for documenting MSRV-aware logic #14662
Changes from all commits
24d3231
721e2cd
57b5f18
5d45b31
c64a063
0667214
6083146
b95fcc2
940e82c
8e872ac
f147d52
16dbce1
0d072e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this table as a quick reference. Could we move it to somewhere such as specifying-dependencies.md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is where to put it. I would normally put it at the beginning of a reference but:
We could have a summary section at the end that also includes the recommendations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either works for me.
Let's not block this PR on this, as the original one was in
resolver.md
, and I don't expect average users to read that chapter. Users above average don't need that either.If someone requests, we can add it back to somewhere.