Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manifest): Provide unused key warnings for lints table #13262

Merged
merged 4 commits into from
Jan 8, 2024
Merged

fix(manifest): Provide unused key warnings for lints table #13262

merged 4 commits into from
Jan 8, 2024

Commits on Jan 8, 2024

  1. test(lints): Check unused key status

    @epage
    epage committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ef6954c View commit details
    Browse the repository at this point in the history

  2. test(lints): Verify we can't un-inherit

    @epage
    epage committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    4760ef7 View commit details
    Browse the repository at this point in the history

  3. refactor(schema): Use dedicated type for 'workspace' field value

    @epage
    epage committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e37a04a View commit details
    Browse the repository at this point in the history

  4. fix(manifest): Provide unused key warnings for lints table 

    The use of `flatten` was getting in the way of `serde_ignored`.
A common workaround is to add our own `unused` tracking but that would
cause duplicates with `workspace.lints` (or we'd just ignore it).

Since the manual deserializer was relatively simple, I went that route.

Fixes rust-lang#12917
    @epage
    epage committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    6e86530 View commit details
    Browse the repository at this point in the history