Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of support for -F as an alias for --features #11774

Merged
merged 3 commits into from
Feb 26, 2023
Merged

Addition of support for -F as an alias for --features #11774

merged 3 commits into from
Feb 26, 2023

Conversation

pea-sys
Copy link
Contributor

@pea-sys pea-sys commented Feb 26, 2023

Updated documentation for #10576

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
weihanglo
weihanglo approved these changes Feb 26, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Do you want to help extract this option for reuse purpose? Like creating a new options-features.md from this, and then reusing it in section-features.md or elsewhere.

@pea-sys
Copy link
Contributor Author

pea-sys commented Feb 26, 2023

@weihanglo
Thanks for your review.
I have split the file so that it is reusable.

@ehuss
Copy link
Contributor

ehuss commented Feb 26, 2023

Do you want to help extract this option for reuse purpose?

I'm not sure why this would be placed into a separate file. The text is specific to the cargo-add command, and I don't think it can be reused anywhere.

@weihanglo
Copy link
Member

Sorry my bad. I thought it was the same as --features in section-features.md but no. @pea-sys could you drop the last commit?

@pea-sys
Copy link
Contributor Author

pea-sys commented Feb 26, 2023

@ehuss
thanks

@weihanglo
It's all right.
Incorrect changes have been reverted.

@weihanglo
Copy link
Member

Sorry for that and thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Feb 26, 2023

📌 Commit b88504a has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
@bors
Copy link
Contributor

bors commented Feb 26, 2023

⌛ Testing commit b88504a with merge e7b11e7...

@bors
Copy link
Contributor

bors commented Feb 26, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing e7b11e7 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Feb 26, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing e7b11e7 to master...

@bors
Copy link
Contributor

bors commented Feb 26, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit e7b11e7 into rust-lang:master Feb 26, 2023
weihanglo added a commit to weihanglo/rust that referenced this pull request Feb 28, 2023
@weihanglo
Update cargo
741f1af 
10 commits in 9d5b32f503fc099c4064298465add14d4bce11e6..9880b408a3af50c08fab3dbf4aa2a972df71e951
2023-02-22 23:04:16 +0000 to 2023-02-28 19:39:39 +0000

- bump jobserver to respect `--jobserver-auth=fifo:PATH` (rust-lang/cargo#11767)
- Addition of support for -F as an alias for --features (rust-lang/cargo#11774)
- Added documentation for the configuration discovery of `cargo install` to the man pages (rust-lang/cargo#11763)
- Fix Cargo removing the sparse+ prefix from sparse URLs in .crates.toml (rust-lang/cargo#11756)
- Fix warning with tempfile (rust-lang/cargo#11771)
- Error message for transitive artifact dependencies with targets the package doesn't directly interact with (rust-lang/cargo#11643)
- Fix tests with nondeterministic ordering (rust-lang/cargo#11766)
- Make some blocking tests non-blocking (rust-lang/cargo#11650)
- Suggest cargo add when installing library crate (rust-lang/cargo#11410)
- chore: bump is-terminal to 0.4.4 (rust-lang/cargo#11759)
@weihanglo weihanglo mentioned this pull request Feb 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 1, 2023
@bors
Auto merge of rust-lang#108582 - weihanglo:update-cargo, r=weihanglo
ca1bc7f 
Update cargo

10 commits in 9d5b32f503fc099c4064298465add14d4bce11e6..9880b408a3af50c08fab3dbf4aa2a972df71e951 2023-02-22 23:04:16 +0000 to 2023-02-28 19:39:39 +0000

- bump jobserver to respect `--jobserver-auth=fifo:PATH` (rust-lang/cargo#11767)
- Addition of support for -F as an alias for --features (rust-lang/cargo#11774)
- Added documentation for the configuration discovery of `cargo install` to the man pages (rust-lang/cargo#11763)
- Fix Cargo removing the sparse+ prefix from sparse URLs in .crates.toml (rust-lang/cargo#11756)
- Fix warning with tempfile (rust-lang/cargo#11771)
- Error message for transitive artifact dependencies with targets the package doesn't directly interact with (rust-lang/cargo#11643)
- Fix tests with nondeterministic ordering (rust-lang/cargo#11766)
- Make some blocking tests non-blocking (rust-lang/cargo#11650)
- Suggest cargo add when installing library crate (rust-lang/cargo#11410)
- chore: bump is-terminal to 0.4.4 (rust-lang/cargo#11759)

r? `@ghost`
@ehuss ehuss added this to the 1.69.0 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

Assignees

@ehuss ehuss

Labels
A-cli-help Area: built-in command-line help A-documenting-cargo-itself Area: Cargo's documentation S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pea-sys @rustbot @ehuss @weihanglo @bors