Fix sparse registry lockfile urls containing 'registry+sparse+' #11177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @weihanglo (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
weihanglo
approved these changes
Oct 7, 2022
Co-authored-by: Weihang Lo <[email protected]>
|
Thank you so much! @bors r+ |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
weihanglo
added a commit
to weihanglo/rust
that referenced
this pull request
Oct 7, 2022
4 commits in 0b84a35c2c7d70df4875a03eb19084b0e7a543ef..3cdf1ab25dc4fe56f890e8c7330d53a23ad905d3 2022-10-03 19:13:21 +0000 to 2022-10-07 17:34:03 +0000 - fix(test): Distinguish 'testname' from escaped arguments (rust-lang/cargo#11190) - Fix sparse registry lockfile urls containing 'registry+sparse+' (rust-lang/cargo#11177) - doc(features2): polish docs a bit (rust-lang/cargo#11185) - Import `cargo remove` into cargo (rust-lang/cargo#11099)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 7, 2022
Update cargo 4 commits in 0b84a35c2c7d70df4875a03eb19084b0e7a543ef..3cdf1ab25dc4fe56f890e8c7330d53a23ad905d3 2022-10-03 19:13:21 +0000 to 2022-10-07 17:34:03 +0000 - fix(test): Distinguish 'testname' from escaped arguments (rust-lang/cargo#11190) - Fix sparse registry lockfile urls containing 'registry+sparse+' (rust-lang/cargo#11177) - doc(features2): polish docs a bit (rust-lang/cargo#11185) - Import `cargo remove` into cargo (rust-lang/cargo#11099)
|
I'm wondering if it might help to add a new |
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Oct 9, 2022
Update cargo 4 commits in 0b84a35c2c7d70df4875a03eb19084b0e7a543ef..3cdf1ab25dc4fe56f890e8c7330d53a23ad905d3 2022-10-03 19:13:21 +0000 to 2022-10-07 17:34:03 +0000 - fix(test): Distinguish 'testname' from escaped arguments (rust-lang/cargo#11190) - Fix sparse registry lockfile urls containing 'registry+sparse+' (rust-lang/cargo#11177) - doc(features2): polish docs a bit (rust-lang/cargo#11185) - Import `cargo remove` into cargo (rust-lang/cargo#11099)
11 tasks
bors
added a commit
that referenced
this pull request
Oct 12, 2022
Add new SourceKind::SparseRegistry to differentiate sparse registries Refactor sparse registry to have its own `SourceKind`. Follow up from #11177 (comment) r? `@ehuss`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Cargo.lockfile for alternative sparse registries incorrectly lists the url asregistry+sparse+rather thansparse+.Fixes #10963