Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use incremental compilation for build scripts #8545

Open
Mark-Simulacrum opened this issue Jul 25, 2020 · 2 comments
Open

Don't use incremental compilation for build scripts #8545

Mark-Simulacrum opened this issue Jul 25, 2020 · 2 comments
Labels
A-profiles Area: profiles S-triage Status: This issue is waiting on initial triage.

Comments

@Mark-Simulacrum
Copy link
Member

Similar to #8500, but going a step further by saying that usually build scripts aren't being edited by users, and even when they are, are quick to compile regardless. Incremental compilation is a net-negative if you're only going to compile once (compare "incremental full" and "full" on https://perf.rust-lang.org/dashboard.html).

This was noted while trying to cut down benchmark times on perf.rust-lang.org.

@ehuss
Copy link
Contributor

ehuss commented Jul 25, 2020

There was some previous discussion about this here: #6577 (comment)

@weihanglo
Copy link
Member

FWIW, there are more relevant discussions happening in #10493.

@epage epage added the S-triage Status: This issue is waiting on initial triage. label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-profiles Area: profiles S-triage Status: This issue is waiting on initial triage.
Projects
None yet
Development

No branches or pull requests

4 participants