Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cfg's in workspaces #8045

Closed
Kixiron opened this issue Mar 27, 2020 · 1 comment
Closed

Allow cfg's in workspaces #8045

Kixiron opened this issue Mar 27, 2020 · 1 comment
Labels
A-workspaces Area: workspaces C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@Kixiron
Copy link
Member

Kixiron commented Mar 27, 2020

Describe the problem you are trying to solve
Cargo should allow wider support for cfgs in the Cargo.toml
For example, I have a workspace member b which I only want to compile for the windows platform, and my intuition tells me that this should work

[target.'cfg(windows)'.workspace]
exclude = ["crates/b"]

However, cargo ignores the cfg in this position, forcing me to manually comment out the exclude in order to compile for other platforms

@Kixiron Kixiron added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Mar 27, 2020
@ehuss ehuss added the A-workspaces Area: workspaces label Apr 15, 2020
@epage
Copy link
Contributor

epage commented Nov 2, 2023

#6179 has solving this as one of its goals. I'm closing in favor of that to consolidate the discussion and as its the more likely route for us to go. If there is a reason for us to reconsider this, let us know!

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-workspaces Area: workspaces C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Development

No branches or pull requests

3 participants