Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo is broken on Windows Docker since #7137 #7313

Closed
zeevm opened this issue Aug 30, 2019 · 3 comments
Closed

Cargo is broken on Windows Docker since #7137 #7313

zeevm opened this issue Aug 30, 2019 · 3 comments
Labels
A-filesystem Area: issues with filesystems C-bug Category: bug O-windows OS: Windows

Comments

@zeevm
Copy link

zeevm commented Aug 30, 2019

7137 introduced using fs::canonicalize in fingerprint.rs (4f6553a)

canonicalize on Windows is implemented using GetFinalPathNameByHandleW which fails on directories that are bind mounted, result being Cargo fails building inside Windows containers when building a source tree that is bind mounted from the host.

To reproduce:

  1. Create a new crate source tree (cargo new) on Windows
  2. Create a Windows container
  3. Start the container and bind mount the source tree inside the container
  4. Build the source tree inside the container

Result: build fails

@zeevm zeevm added the C-bug Category: bug label Aug 30, 2019
@alexcrichton
Copy link
Member

Thanks for the report! Can you gist the error message coming out of this?

Also cc @ehuss, you might be interested in this!

@ehuss ehuss added the A-filesystem Area: issues with filesystems label Sep 21, 2019
@sloutsky
Copy link

This issue becomes critical to us. Can you please comment if any fix is planned soon?

@ehuss ehuss added the O-windows OS: Windows label Apr 5, 2022
@ehuss
Copy link
Contributor

ehuss commented Apr 15, 2023

I'm going to close as I cannot reproduce the original issue. Perhaps an update in Docker or Windows has fixed the filesystem issue. Additionally, #11866 has been merged which does a fallback for canonicalization.

If anyone can reproduce this on the latest nightly, please include a complete reproduction, including a Dockerfile, the version of Docker and Windows, WSL information, etc.

@ehuss ehuss closed this as completed Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-filesystem Area: issues with filesystems C-bug Category: bug O-windows OS: Windows
Projects
None yet
Development

No branches or pull requests

4 participants