Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message suggesting --allow-dirty should clearly specify what will happen when it is specified #7003

Closed
nagisa opened this issue Jun 3, 2019 · 0 comments · Fixed by #7083
Closed

Message suggesting --allow-dirty should clearly specify what will happen when it is specified #7003

nagisa opened this issue Jun 3, 2019 · 0 comments · Fixed by #7083
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself. C-bug Category: bug E-easy Experience: Easy

Comments

@nagisa
Copy link
Member

nagisa commented Jun 3, 2019

Problem

When publishing with dirty files in tree cargo prints a message:

error: 2 files in the working directory contain changes that were not yet committed into git:

out
src/os/unix/global_static.ll

to proceed despite this, pass the `--allow-dirty` flag

however it does not specify what will happen if --allow-dirty is specified. It should unambiguously mention that specifying this flag will include the dirty files.

Possible Solution(s)

to proceed despite this and include the dirty files, pass the --allow-dirty flag
@nagisa nagisa added the C-bug Category: bug label Jun 3, 2019
@ehuss ehuss added A-diagnostics Area: Error and warning messages generated by Cargo itself. E-easy Experience: Easy labels Jun 24, 2019
@sekhat sekhat mentioned this issue Jul 1, 2019
Merged
bors added a commit that referenced this issue Jul 1, 2019
@bors
Auto merge of #7083 - sekhat:issue/7003-allow-dirty, r=alexcrichton
092b8f2 
improve uncommitted changes cargo-package message

fixes #7003

Explicitly state what the suggested flag `--allow-dirty`
actually does when packaging/publishing the crate. Primarily,
that the uncommitted changes are included within the resulting
package.
@bors bors closed this as completed in #7083 Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Error and warning messages generated by Cargo itself. C-bug Category: bug E-easy Experience: Easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve uncommitted changes cargo-package message
2 participants
@ehuss @nagisa