-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo check
fails oddly on binaries
#3419
Comments
looking into this... |
This appears to be fixed by #3425. Will submit a PR with a test... |
bors
added a commit
that referenced
this issue
Dec 26, 2016
Test for #3419 Based on top of #3425. I'm not sure if this is an acceptable test because it downloads rustc-serialize. r? @alexcrichton
2 tasks
bors
added a commit
that referenced
this issue
Mar 25, 2024
Remove unnecessary test This removes a test that is blocking rust-lang/rust#116016 from landing. `@dtolnay` suggested removing the test rather than allowing the relevant lints ([comment](rust-lang/rust#116016 (comment))). > The failure is in https://github.com/rust-lang/cargo/blob/77506e57392d94450bb3ed52cf75e3263bbb2792/tests/testsuite/check.rs#L222-L285 which is a 7 year old test for [#3419](#3419), which is from 2 days after the initial implementation of `cargo check` landed in nightly Cargo in [#3296](#3296). > > I would recommend just deleting the test from Cargo. The implementation of `cargo check` has matured enough since then and I don't see anything useful in that test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Not entirely sure what's going on here....
With that structure:
@nrc mind taking a look?
The text was updated successfully, but these errors were encountered: