Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors in console output not working in conhost #2803

Closed
retep998 opened this issue Jun 26, 2016 · 0 comments
Closed

Colors in console output not working in conhost #2803

retep998 opened this issue Jun 26, 2016 · 0 comments

Comments

@retep998
Copy link
Member

retep998 commented Jun 26, 2016 •
edited
Loading

When using cargo in the Windows console, it doesn't use colors. Even --color=always doesn't work. The output from rustc is colored though, just not cargo itself.

https://github.com/rust-lang/cargo/blob/master/src/cargo/core/shell.rs#L150-L172

It explicitly uses TermInfo and ignores Windows entirely. That function can't even be easily fixed due to it taking a Box<Write + Send>, so the API for Shell::create and every user of it would have to be changed.
@skeleten skeleten mentioned this issue Jun 26, 2016
Merged
@chris-morgan chris-morgan mentioned this issue Jun 26, 2016
Closed
bors added a commit that referenced this issue Jun 29, 2016
@bors
Auto merge of #2804 - skeleten:master, r=alexcrichton
5716f32 
Add color support for Windows consoles

Unfortunately, the `term` API makes this PR rather inelegant, any hints/pointers to make it better are highly appreciated!

Fixes #2803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@retep998