Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo doc --open regression on Windows #2446

Closed
SpaceManiac opened this issue Mar 7, 2016 · 2 comments · Fixed by #2780
Closed

cargo doc --open regression on Windows #2446

SpaceManiac opened this issue Mar 7, 2016 · 2 comments · Fixed by #2780

Comments

@SpaceManiac
Copy link

On Windows 7, cargo doc --open has stopped working between stable and beta, instead failing silently. I was unable to find any obvious offending commits in the diff, or compile Cargo to narrow down the commit range myself.

Working: cargo 0.8.0-nightly (28a0cbb 2016-01-17)
Broken:  cargo 0.9.0-nightly (8fc3fd8 2016-02-29)
@pravic
Copy link

pravic commented Mar 25, 2016

Confirming, same issue for me:
cargo 0.10.0-nightly (61ad6a0 2016-03-22)

@SpaceManiac
Copy link
Author

Still exhibiting the problem on versions:

cargo 0.10.0-nightly (10ddd7d 2016-04-08)
cargo 0.11.0-nightly (59238e8 2016-04-14)

The output now ends with:

   Launching cmd /C start

Boddlnagg added a commit to Boddlnagg/cargo that referenced this issue Jun 10, 2016
@Boddlnagg
Fix cargo doc --open on Windows
b9a4ef1 
This fixes rust-lang#2446. Note that I have not built cargo with this change, but I have tested the functionality in isolation (on Windows 10).

As to the issue itself, I don't know why the previous version didn't work, but `start` is redundant when `cmd /C` is used.
@Boddlnagg Boddlnagg mentioned this issue Jun 10, 2016
Merged
bors added a commit that referenced this issue Jun 10, 2016
@bors
Auto merge of #2780 - Boddlnagg:patch-1, r=alexcrichton
22f9cff 
Fix `cargo doc --open` on Windows

This fixes #2446. Note that I have not built cargo with this change, but I have tested the functionality in isolation (on Windows 10).

As to the issue itself, I don't know why the previous version didn't work, but `start` is redundant when `cmd /C` is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cargo doc --open on Windows Boddlnagg/cargo
2 participants
@SpaceManiac @pravic