Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-timing.html supports dark mode #14586

Closed
ahaoboy opened this issue Sep 24, 2024 · 1 comment · Fixed by #14588
Closed

cargo-timing.html supports dark mode #14586

ahaoboy opened this issue Sep 24, 2024 · 1 comment · Fixed by #14588
Labels
A-timings Area: timings C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.

Comments

@ahaoboy
Copy link
Contributor

ahaoboy commented Sep 24, 2024

Problem

For users using dark mode, opening cargo-timing.html is very glaring

I can use some browser ext to force the web page to switch to dark mode, but the canvas will still be white background.

Image

Proposed Solution

For web pages, there is already prefers-color-scheme

https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

For canvas, maybe just invert the basic white and black, and keep the other colors?

Notes

No response

@ahaoboy ahaoboy added C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-triage Status: This issue is waiting on initial triage. labels Sep 24, 2024
@weihanglo weihanglo added S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing. A-timings Area: timings and removed S-triage Status: This issue is waiting on initial triage. labels Sep 24, 2024
@weihanglo
Copy link
Member

Thanks for the proposal. This is a good feature, though I don't think any of the maintainers has time to either mentor or design it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-timings Area: timings C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` S-needs-mentor Status: Issue or feature is accepted, but needs a team member to commit to helping and reviewing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants