Warn on unknown keys in lint table entries #12917
Labels
A-lints-table
Area: [lints] table
C-bug
Category: bug
S-accepted
Status: Issue or feature is accepted, and has a team member available to help mentor or review
Comments
Alexendoo
added
C-bug
|
Yeah, we should add a |
epage
added
S-accepted
|
btw allowing configuration in there is a future possibility though previously a clippy team member said they wouldn't use it. |
|
The tool-wide section from that link looks like it would be a better fit for us yeah |
epage
added a commit
to epage/cargo
that referenced
this issue
Jan 8, 2024
The use of `flatten` was getting in the way of `serde_ignored`. A common workaround is to add our own `unused` tracking but that would cause duplicates with `workspace.lints` (or we'd just ignore it). Since the manual deserializer was relatively simple, I went that route. Fixes rust-lang#12917
bors
added a commit
that referenced
this issue
Jan 8, 2024
fix(manifest): Provide unused key warnings for lints table ### What does this PR try to resolve? The use of `flatten` was getting in the way of `serde_ignored`. A common workaround is to add our own `unused` tracking but that would cause duplicates with `workspace.lints` (or we'd just ignore it). Since the manual deserializer was relatively simple, I went that route. Fixes #12917 ### How should we test and review this PR? Per commit A test was added for the issue. I then was worried about regressions in `workspace = false` errors (and I was right) so I added a test for that. To get `workspace = false` to work nicely, I made it share code with other `workspace: bool` fields. ### Additional information
stupendoussuperpowers
pushed a commit
to stupendoussuperpowers/cargo
that referenced
this issue
Feb 28, 2024
The use of `flatten` was getting in the way of `serde_ignored`. A common workaround is to add our own `unused` tracking but that would cause duplicates with `workspace.lints` (or we'd just ignore it). Since the manual deserializer was relatively simple, I went that route. Fixes rust-lang#12917
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
In rust-lang/rust-clippy#11751 a user had
Expecting the
doc_valid_identsto set the clippy configuration of the same name, however it is silently ignored by cargoSteps
No response
Possible Solution(s)
No response
Notes
No response
Version
No response
The text was updated successfully, but these errors were encountered: