You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following tests are blocking for a minute waiting for a publish that never finishes:
alt_registry::publish_to_alt_registry
alt_registry::publish_with_crates_io_dep
alt_registry::publish_with_registry_dependency
This is a multi-part issue:
Fix these tests so they don't block.
Change these tests so that they use with_stderr to validate their output (which would have caught this regression).
Avoid the "hack" added in Fix several tests that are waiting 60 seconds for publishing to time out #11388. I'm not sure what the best approach would be here. One would be to spin up the publish server so that instead of cargo just writing the new file, it would actually speak HTTP. Another is to disable the delay. Probably some other options are viable as well.
(And similarly update those tests to validate their output.)
Implement something to prevent this from happening in the future. I'm not sure about the best approach here, but perhaps something like if cargo publish fails to wait for the propagation, to fail the test.
sigh when originally implementing this, the timeouts were hard to find and deal with in tests. I appreciate cargo nextest highlights overly long test cases and wish that was more generally available.
The following tests are blocking for a minute waiting for a publish that never finishes:
alt_registry::publish_to_alt_registry
alt_registry::publish_with_crates_io_dep
alt_registry::publish_with_registry_dependency
This is a multi-part issue:
with_stderr
to validate their output (which would have caught this regression).new
file, it would actually speak HTTP. Another is to disable the delay. Probably some other options are viable as well.(And similarly update those tests to validate their output.)
cargo publish
fails to wait for the propagation, to fail the test.cc @arlosi
The text was updated successfully, but these errors were encountered: