-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obey the return value from the trace visitor under Miri #476
Conversation
Is the point that
Did you check that this PR fixes that? |
Under Linux it shows about the same kinds of frames, I don't see anything being pruned:
|
(I agree this is what the |
How are you testing this? I checked out this branch into the backtrace submodule in my Rust checkout, then on this Cargo project: fn main() {
panic!("ow");
}
#[test]
fn oof() {
panic!("ow");
} I'm setting
|
As I said, I did |
Ah 🤦 Picking through the code in |
Looks reasonable to me, thanks for this! I think the CI issues are unrelated so I'll go ahead and merge. |
We're supposed to stop visiting backtrace frames when the visitor returns
false
, but this used to just ignore the return value.It's entirely possible that backtrace pruning has never worked under Miri due to this bug, and nobody noticed because the slowness in rust-lang/miri#2273 which this bug contributes significantly to. Wonderfully circular.
cc @RalfJung