Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to create PE import libraries #15

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

dpaoliello
Copy link
Contributor

Now that we can generate COFF archives, we can also generate import libraries by setting up an archive with the correct members.

This can then be used in the Rust compiler to implement the raw-dylib feature.

  • Ports the code from COFFImportFile.cpp to generate import libraries.
  • Adds tests to compare the import libraries to llvm-lib and llvm-dlltool.

src/coff.rs Outdated Show resolved Hide resolved
src/coff_import_file.rs Outdated Show resolved Hide resolved
reference/COFFImportFile.h Outdated Show resolved Hide resolved
src/coff_import_file.rs Outdated Show resolved Hide resolved
src/coff_import_file.rs Outdated Show resolved Hide resolved
src/coff_import_file.rs Outdated Show resolved Hide resolved
src/coff_import_file.rs Show resolved Hide resolved
src/coff_import_file.rs Outdated Show resolved Hide resolved
src/coff_import_file.rs Outdated Show resolved Hide resolved
src/coff_import_file.rs Outdated Show resolved Hide resolved
@dpaoliello dpaoliello requested a review from bjorn3 July 24, 2024 22:20
@bjorn3 bjorn3 merged commit e2103f2 into rust-lang:master Jul 25, 2024
2 checks passed
@bjorn3
Copy link
Member

bjorn3 commented Jul 25, 2024

Thanks a lot for working on this!

@bjorn3 bjorn3 removed their request for review July 25, 2024 16:50
@bjorn3
Copy link
Member

bjorn3 commented Jul 25, 2024

Published as 0.3.1.

@bjorn3
Copy link
Member

bjorn3 commented Jul 25, 2024

I've opened rust-lang/rust#128206 as first step towards wiring this up in cg_clif.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants