This repository has been archived by the owner on Aug 20, 2021. It is now read-only.
Bugfix/refactor #34
Merged
Bugfix/refactor #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
opilar
commented
May 12, 2017
opilar
commented
- replace try macro with ?
- clean compiler warning
```
warning: length comparison to zero
--> src/lib.rs:203:27
|
203 | let leaf = if prefix.len() > 0 {
| ^^^^^^^^^^^^^^^^ help: using `is_empty` is more concise: `!prefix.is_empty()`
|
= note: #[warn(len_zero)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#len_zero
```
|
@brson can somebody review that? |
|
Oop sorry for the delay, thanks for the PR! |
opilar
pushed a commit
to opilar/tempdir
that referenced
this pull request
Sep 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.