Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression of PR #916 #1304

Closed
stouset opened this issue Apr 5, 2018 · 1 comment
Closed

Regression of PR #916 #1304

stouset opened this issue Apr 5, 2018 · 1 comment

Comments

@stouset
Copy link
Contributor

stouset commented Apr 5, 2018

#916 regressed due to the changes in #915. Specifically, due to eeec4bd.
@emilio
Copy link
Contributor

emilio commented Apr 6, 2018

Indeed. If this is still interesting to somebody I'm happy to rubber-stamp a patch to reland that.

This was referenced May 24, 2018
Closed
Merged
bors-servo pushed a commit that referenced this issue May 29, 2018
Auto merge of #1321 - stouset:check-if-num-template-args-is-loaded, r…
1f097dd 
…=emilio

Check if `clang_Type_getNumTemplateArguments` is loaded before use

Fixes #1304, which reapplies #916 which was regressed by #915.
kulp added a commit to kulp/rust-bindgen that referenced this issue Jun 22, 2020
@kulp
Remove obsoleted is_loaded checks
9902631 
It is not clear what version of libclang these supported.

Refer to rust-lang#1321, rust-lang#1304, rust-lang#916, rust-lang#915.
kulp added a commit to kulp/rust-bindgen that referenced this issue Jun 24, 2020
@kulp
Remove obsoleted is_loaded checks
64333c0 
It is not clear what version of libclang these supported.

Refer to rust-lang#1321, rust-lang#1304, rust-lang#916, rust-lang#915.
kulp added a commit to kulp/rust-bindgen that referenced this issue Jun 28, 2020
@kulp
Remove obsoleted is_loaded checks
4e6a2fb 
It is not clear what version of libclang these supported.

Refer to rust-lang#1321, rust-lang#1304, rust-lang#916, rust-lang#915.
kulp added a commit to kulp/rust-bindgen that referenced this issue Jun 29, 2020
@kulp
Remove obsoleted is_loaded checks
5706359 
It is not clear what version of libclang these supported.

Refer to rust-lang#1321, rust-lang#1304, rust-lang#916, rust-lang#915.
kulp added a commit to kulp/rust-bindgen that referenced this issue Jul 17, 2020
@kulp
Remove obsoleted is_loaded checks
c30b753 
It is not clear what version of libclang these supported.

Refer to rust-lang#1321, rust-lang#1304, rust-lang#916, rust-lang#915.
kulp added a commit to kulp/rust-bindgen that referenced this issue Jul 20, 2020
@kulp
Remove obsoleted is_loaded checks
c6d9d54 
It is not clear what version of libclang these supported.

Refer to rust-lang#1321, rust-lang#1304, rust-lang#916, rust-lang#915.
emilio pushed a commit that referenced this issue Jul 20, 2020
@kulp @emilio
Remove obsoleted is_loaded checks
3e2566d 
It is not clear what version of libclang these supported.

Refer to #1321, #1304, #916, #915.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stouset @emilio