Skip to content

Commit

Permalink
Unrolled build for rust-lang#133813
Browse files Browse the repository at this point in the history
Rollup merge of rust-lang#133813 - clubby789:ui-pass-note, r=jieyouxu

compiletest: explain that UI tests are expected not to compile by default

```
error: ui test compiled successfully!
```
is not a very useful message for someone new to the test suite, so change the wording and add a note to explain
  • Loading branch information
rust-timer authored Dec 4, 2024
2 parents c44b3d5 + ab38efe commit 64b6047
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions src/tools/compiletest/src/runtest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -350,10 +350,13 @@ impl<'test> TestCx<'test> {
}
} else {
if proc_res.status.success() {
self.fatal_proc_rec(
&format!("{} test compiled successfully!", self.config.mode)[..],
proc_res,
);
{
self.error(&format!("{} test did not emit an error", self.config.mode));
if self.config.mode == crate::common::Mode::Ui {
println!("note: by default, ui tests are expected not to compile");
}
proc_res.fatal(None, || ());
};
}

if !self.props.dont_check_failure_status {
Expand Down

0 comments on commit 64b6047

Please sign in to comment.