Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all_equal vs. all_equal_value #975

Open
IttayWeiss opened this issue Jul 29, 2024 · 0 comments
Open

all_equal vs. all_equal_value #975

IttayWeiss opened this issue Jul 29, 2024 · 0 comments

Comments

@IttayWeiss
Copy link

IttayWeiss commented Jul 29, 2024

It seems to be a fair expectation that all_equal_value().is_ok() should agree with all_equal(). But on an empty iterator the former returns false, while the latter returns true.

Can be resolved by keeping the current behaviour of all_equal (which is the mathematical definition whereby on an empty iterator vacuously all items are equal) and changing the return type of all_equal_value to Result<Option<Iter::Item>, (Iter::Item, Iter::Item)>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant