Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove lint #![deny(const_err)] #672

Merged
merged 1 commit into from
Oct 15, 2022
Merged

fix: remove lint #![deny(const_err)] #672

merged 1 commit into from
Oct 15, 2022

Conversation

luojia65
Copy link
Contributor

This lint has been removed in Rust, see: #669 . We remove it here to avoid compile warnings.

Before this pull request, every peripheral access crate this software generates will emit following warning upon compilation:

warning: lint `const_err` has been removed: converted into hard error, see issue #71800 <https://github.com/rust-lang/rust/issues/71800> for more information
 --> src\lib.rs:3:9
  |
3 | #![deny(const_err)]
  |         ^^^^^^^^^
  |
  = note: `#[warn(renamed_and_removed_lints)]` on by default

@luojia65 luojia65 requested a review from a team as a code owner October 15, 2022 03:21
@rust-highfive
Copy link

r? @reitermarkus

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Oct 15, 2022
Emilgardis
Emilgardis requested changes Oct 15, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@Emilgardis
Copy link
Member

could you squash the commits, feel free to drop my "Co-authored by" line in the message

@luojia65 @Emilgardis
fix: remove lint #![deny(const_err)]
630c523 
This lint has been removed in Rust, see: rust-embedded#669 . We remove it here to avoid compile warnings.

Signed-off-by: Luo Jia <[email protected]>
Co-authored-by: Emil Gardström <[email protected]>
@luojia65
Copy link
Contributor Author

@Emilgardis Hi! I squashed 2 commits.

Emilgardis
Emilgardis approved these changes Oct 15, 2022
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

bors r=burrbull,emilgardis

@bors
Copy link
Contributor

bors bot commented Oct 15, 2022

Build succeeded:

@bors bors bot merged commit 778087b into rust-embedded:master Oct 15, 2022
@luojia65 luojia65 deleted the patch-1 branch October 15, 2022 11:06
@duskmoon314 duskmoon314 mentioned this pull request Oct 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burrbull burrbull burrbull approved these changes

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees

@reitermarkus reitermarkus

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luojia65 @rust-highfive @Emilgardis @burrbull @reitermarkus