Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minimal dependency build #361

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Fix minimal dependency build #361

merged 1 commit into from
Nov 25, 2021

Conversation

Sh3Rm4n
Copy link
Contributor

@Sh3Rm4n Sh3Rm4n commented Nov 1, 2021

With

cargo +nightly update -Z minimal-versions
cargo build

Following error occurred:

bare-metal v0.2.1: const_fn feature has been removed 
$ cargo +nightly update -Z minimal-versions
    Updating crates.io index
    Updating bare-metal v0.2.5 -> v0.2.1
    Updating embedded-hal v0.2.6 -> v0.2.4
    Removing nb v0.1.3
    Removing nb v1.0.0
      Adding nb v0.1.1
    Removing rustc_version v0.2.3
    Removing semver v0.9.0
    Removing semver-parser v0.7.0
    Updating vcell v0.1.3 -> v0.1.0
    Updating volatile-register v0.2.1 -> v0.2.0
$ cargo build
  Downloaded vcell v0.1.0
  Downloaded nb v0.1.1
  Downloaded 2 crates (15.4 KB) in 1.02s
   Compiling vcell v0.1.0
   Compiling void v1.0.2
   Compiling nb v0.1.1
   Compiling bare-metal v0.2.1
error[E0557]: feature has been removed
 --> /home/fabian/.cargo/registry/src/github.com-1ecc6299db9ec823/bare-metal-0.2.1/src/lib.rs:7:13
  |
7 |     feature(const_fn, const_unsafe_cell_new)
  |             ^^^^^^^^ feature has been removed
  |
  = note: split into finer-grained feature gates

error[E0554]: `#![feature]` may not be used on the stable release channel
 --> /home/fabian/.cargo/registry/src/github.com-1ecc6299db9ec823/bare-metal-0.2.1/src/lib.rs:7:5
  |
7 |     feature(const_fn, const_unsafe_cell_new)
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Some errors have detailed explanations: E0554, E0557.
For more information about an error, try `rustc --explain E0554`.
error: could not compile `bare-metal` due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: build failed

Setting the minimal version of bare-metal to v0.2.4 fixes the issue.

@Sh3Rm4n Sh3Rm4n requested a review from a team as a code owner November 1, 2021 07:02
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @adamgreig (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Nov 1, 2021
Sh3Rm4n added a commit to Sh3Rm4n/stm32f3xx-hal that referenced this pull request Nov 17, 2021
@Sh3Rm4n
Fix minimal dependency build
d5f6297 
Workaround the cortex-m -> bare-metal 0.2.1
dependency by depending on bare-metal 0.2.5
directly, as long as

rust-embedded/cortex-m#361

is not fixed.
@Sh3Rm4n Sh3Rm4n mentioned this pull request Nov 17, 2021
Merged
@jonathanpallant
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 25, 2021

Build succeeded:

@bors bors bot merged commit 4b53689 into rust-embedded:master Nov 25, 2021
@adamgreig adamgreig mentioned this pull request Dec 31, 2021
Merged
bors bot added a commit that referenced this pull request Jan 2, 2022
@bors @adamgreig
Merge #375
2e2cb78 
375: Prepare v0.7.4 r=thejpster a=adamgreig

I've created a new branch, `v0.7.x`, which is currently at the latest non-breaking commit (so includes #346 #349 #347 #351 #339 #352 #348 #363 #362 #361 but does not include #342), to track the 0.7 series since master now contains breaking changes for v0.8.

This PR (which targets the new branch) cherry-picks #372 #369 #374 and bumps the version to v0.7.4 (and updates CHANGELOG) ready for a new v0.7.4 release. Once complete I'll also backport the changelog entries and bump the version in master to 0.7.4.

I think this is everything that should be in 0.7 -- the only excluded PRs from master are #342 and #367 I believe, and I don't think we have any open PRs targeting 0.7 either.

Any other thoughts on items for inclusion in 0.7.4 (or other changelog entries I missed)?

Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Co-authored-by: Adam Greig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpallant jonathanpallant jonathanpallant approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sh3Rm4n @rust-highfive @jonathanpallant @adamgreig