Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Rust 2018 syntax? #41

Closed
thejpster opened this issue Oct 10, 2018 · 6 comments · Fixed by #340
Closed

Use Rust 2018 syntax? #41

thejpster opened this issue Oct 10, 2018 · 6 comments · Fixed by #340

Comments

@thejpster
Copy link
Contributor

Should we be using Rust 2018 syntax in the book? The main change would be removing extern crate statements.
@hyperslv
Copy link
Contributor

agree but the suggested change has to be synchronized with the appropriate change in source code of the examples at github.com/rust-embedded/cortex-m-quickstart .
I will help & fix both if someone explains me how to synchronize these Repos

@therealprof
Copy link
Contributor

What do you mean by synchronize? Open PRs on both and then we'll merge them, couldn't be easier. 😅

@hyperslv hyperslv mentioned this issue Jun 13, 2020
Merged
@hyperslv
Copy link
Contributor

Created a PR on this issue

bors bot added a commit that referenced this issue Jun 14, 2020
@bors @hyperslv
Merge #248
9387745 
248: Provide a note on 'extern crate' usage in edition 2018 syntax of Rust r=adamgreig a=hyperslv

I was confused reading 'extern crate' in the examples of the book since it looks like old Rust syntax and encounters quite rare nowadays. So it is looked like not-updated. I saw an [issue](#41) which tells that other people also had same thoughts. So my change is to make it clear that usage of this declaration form is intended and not-updated.

Co-authored-by: hyperslv <[email protected]>
Co-authored-by: hyperslv <[email protected]>
@hyperslv
Copy link
Contributor

This issue might be closed since the appropriate PR was merged.

@Narukara
Copy link
Contributor

There are still some extern crate statements in the book. For example:

book/src/peripherals/singletons.md

Line 65 in 19f798d

extern crate cortex_m;

book/src/collections/index.md

Line 33 in 09986cd

extern crate alloc;

Shall we fix them all?

@eldruin
Copy link
Member

eldruin commented Jan 17, 2023

@Narukara I would welcome a PR fixing them all. We could then close this issue.

@Narukara Narukara mentioned this issue Jan 17, 2023
Merged
@bors bors bot closed this as completed in c7e7903 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove extern crate statements
5 participants
@eldruin @thejpster @therealprof @Narukara @hyperslv