This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
Updates for save-analysis #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should |
nrc
reviewed
Jan 28, 2018
src/lib.rs
Outdated
| @@ -254,6 +254,7 @@ pub struct Relation { | |||
| pub kind: RelationKind, | |||
| pub from: Id, | |||
| pub to: Id, | |||
| pub id: u32, | |||
There was a problem hiding this comment.
This looks like it should be in RelationKind::Impl rather than Relation, since SuperTrait won't have such an id
This reverts commit 8629394.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To emit
rls-data::Implin rust save-analysis, we need some changes.