Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May is mentioned in the docs but is not used #5

Open
matklad opened this issue Feb 3, 2018 · 4 comments
Open

May is mentioned in the docs but is not used #5

matklad opened this issue Feb 3, 2018 · 4 comments
Assignees
Labels

Comments

@matklad
Copy link

matklad commented Feb 3, 2018

The docs mention the may library, but it isn’t even in Cargo.toml. BTW, may is an unsafe library, so I am not sure if it is a good idea to promote it...

@vitiral
Copy link
Contributor

vitiral commented Feb 3, 2018 via email

@vitiral
Copy link
Contributor

vitiral commented Feb 3, 2018 via email

@matklad
Copy link
Author

matklad commented Feb 3, 2018

Hm, yeah, I’ve skimmed the docs too fast :-) However, I would still advise against promoting may: it may lead to ub if TLS is used, and a lot of stuff in Rust uses or may use TLS.

See Xudong-Huang/may#6 for the context, and the implementation of the go! macro which masks unsafety without providing any kind of guarantees: https://github.com/Xudong-Huang/may/blob/e2312d5871bfea5b1f4a0f89aafa59c7cff880b9/src/macros.rs#L19

Disclaimer: I have not used may, and I am not an expert in coroutines, so I might be embarrassingly wrong here :)

@vitiral
Copy link
Contributor

vitiral commented Feb 3, 2018

I did notice that in their docs. I can point it out explicitly in ergo_sync's docs as well. Thanks!

@vitiral vitiral added the docs label Feb 3, 2018
@vitiral vitiral self-assigned this Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants