Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace error-chain with thiserror #58

Closed
matthiasbeyer opened this issue Sep 12, 2022 · 1 comment · Fixed by #59
Closed

Replace error-chain with thiserror #58

matthiasbeyer opened this issue Sep 12, 2022 · 1 comment · Fixed by #59

Comments

@matthiasbeyer
Copy link
Member

I would like to replace the (seemingly abandoned) error-chain dependency with the maintained thiserror.

Does anyone object? @petreeftime?

rexpect has a lot of unwrap()/expect() calls in the codebase, which I would like to review after moving to thiserror (and hopefully fix, of course).
@petreeftime
Copy link
Collaborator

Sounds good to me. error-chain seems deprecated.

@matthiasbeyer matthiasbeyer mentioned this issue Sep 12, 2022
Merged
@bors bors bot closed this as completed in #59 Sep 12, 2022
This was referenced Sep 12, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace error-chain with thiserror matthiasbeyer/rexpect
2 participants
@matthiasbeyer @petreeftime