Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify deser impl #338

Closed
wants to merge 2 commits into from
Closed

Unify deser impl #338

wants to merge 2 commits into from

Commits on May 11, 2022

  1. Introduce an error test case for deserialising a whole struct 

    This tests, in particular, that the error messdage is as expected
including the right key and filename.
    @ijackson
    ijackson committed May 11, 2022
    Configuration menu
    Copy the full SHA
    db16b56 View commit details
    Browse the repository at this point in the history

  2. impl Deserializer for Config: forward everything to cache 

    This had open-coded copies of the impl for Value.  Replace them with
calls to the impl for Value.  This reduces duplication.  It would
allow us to change the impl for Value.

Use a macro for the many very-similar functions.
    @ijackson
    ijackson committed May 11, 2022
    Configuration menu
    Copy the full SHA
    5d63f20 View commit details
    Browse the repository at this point in the history