Add getter for getting a &mut Value from Config #165
Conversation
This function can be used to alter values while loading stuff into the Config object. Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
|
Okay, so I was able to confirm that this is a possible way to implement the feature I need. Here's how I use this feature now: https://git.beyermatthi.as/butido/commit/?h=pathes-to-absolute&id=370d6bc6e5140d5fa26c0c7029bc1269e9b0c9ad I think we can start a discussion about this. Please note that my patch linked above is not perfect. As you can see if you browse the source file as whole, I'm recursively loading files and the patch has issues with that because later recursion overwrites prior steps. Edit: |
|
btw, it looks like the CI failure is not caused by me, is it? |
|
Superseded and thus not relevant anymore. |
This patch ensures that pathes for patches are always relative to the repository root, when loading the packages layered from the repository. The problem is well described in the comment in the code, so this commit message ends here. This patch was written using an proposed feature for the config-rs dependency: rust-cli/config-rs#165 This PR added a `Config::get_value_mut()` function and exported the `config::value::ValueKind` type in config-rs public API. Signed-off-by: Matthias Beyer <[email protected]> Tested-by: Matthias Beyer <[email protected]>
This is a (maybe possible) solution for #163
This is, of course, not as nice as it could be, because it exposes interior of this crate to the user.
I'm currently experimenting with these patches in my source, to see whether such a thing is feasible at all.
Feel free to ignore until I reached a state where it works, then we can debate over it.