Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HOCON as a config file format #103

Closed
wants to merge 1 commit into from

Conversation

mockersf
Copy link

@mockersf mockersf commented Mar 8, 2019

Default features of the hocon library are disabled.

The two features disabled are:

  • serde support, which this crate already does
  • include url(...) hocon syntax support, which needs a dependency on reqwest even though it won't be used in most cases

@mehcode
Copy link
Collaborator

mehcode commented May 9, 2019

🙇‍♂️ Thank you for your contribution. I apologize for the late response. Moving forward I want to re-think the design of config as a whole. See #111 for more details.


Going to close because how we add file formats is going to change pretty drastically. There is a lot of duplicated code in the different formats.

Thank you again though.

As a future point we can probably support a feature flag like hocon_url to turn on include support.

@mehcode mehcode closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants