Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the project maintained? #149

Closed
LukeMathWalker opened this issue Aug 23, 2020 · 22 comments
Closed

Is the project maintained? #149

LukeMathWalker opened this issue Aug 23, 2020 · 22 comments

Comments

@LukeMathWalker
Copy link
Collaborator

Hello!
config is a key component in many of my projects and I'd like to contribute back some functionality/bug fixes.
Looking at PRs and issues, there seems to have been little to no activity on the project for the past 10 months or so.

Should the project be considered unmaintained or is it just temporary?
Not interested in pressuring you to work on it, just trying to understand if, instead of contributing PRs, it might make more sense to start a fork to evolve it.

@szarykott
Copy link
Contributor

Hello! I am also interested in answer to this question as I see few lacking features.
@LukeMathWalker In case you this project is not maintained, let me know if you fork as I would be interesed in comiting some stuff, but I do not see any benefit of doubling some work (in case you want to push your fork to crates.io ofc)

@mehcode
Copy link
Collaborator

mehcode commented Sep 3, 2020

👋

I don't mind giving commit access to this. I have had a lot of ideas on where to take it but I haven't had the time to work on them.

@mehcode
Copy link
Collaborator

mehcode commented Sep 3, 2020

I added you both and anyone with a pending PR.

cc

@dawid-nowak
@eisterman
@ignatenkobrain
@joelgallant
@LukeMathWalker
@szarykott
@up9cloud
@vmalloc


Let's aim to keep the spirit of the crate but I'll be fine with most changes as long as we don't remove capabilities (as the crate has been around for awhile now, I'm sure even some weird feature I don't realize exists is being used somewhere).

Feel free to ping me here or on discord ( mehcode ) to chat about any design questions.

Good luck and I hope this project can pick back up.

@vmalloc
Copy link
Collaborator

vmalloc commented Sep 3, 2020

@mehcode thanks! Where on Discord exactly? one needs either a server you're in or your tag to DM you...

@mehcode
Copy link
Collaborator

mehcode commented Sep 3, 2020

@vmalloc Apologies. I meant the Rust discord. I'm present in the official one and the unofficial one.

https://www.rust-lang.org/community

@joelgallant
Copy link
Collaborator

We've used it at work, and personally (somewhat similar to our typescript package). Happy to help with maintenance and improvements. Maybe we could set up a dedicated discord channel for discussions?

Other thing would (eventually) be crates.io publishing rights, looks like @filipegoncalves is a contributor on crates.io as well.

@LukeMathWalker
Copy link
Collaborator Author

Thanks a lot for taking this step @mehcode 🙏
I'd say that the first step is going through the open PRs and see what is ready to be merged/what requires additional work.

@joelgallant
Copy link
Collaborator

I'll start/have started looking through the backlog here for easy wins to start with. If there's some strategy or direction others want to take with this, I'd love to help.

@joelgallant
Copy link
Collaborator

#111 is certainly relevant here

@szarykott
Copy link
Contributor

Maybe trying to close issues no longer relevant?

@matthiasbeyer
Copy link
Member

@mehcode I hope that push access to master is not allowed on this repository? 😆

@fpoli
Copy link

fpoli commented Feb 1, 2021

@dawid-nowak @eisterman @ignatenkobrain @joelgallant @LukeMathWalker @szarykott @up9cloud @vmalloc
Is any of you actually interested in maintaining the project (which, btw, is really cool and widely used)? If not, we could post a call for maintainers on https://users.rust-lang.org/.

I'm personally interested in taking care of #164, #157 and I could propose a PR to add a CommandLine Source, but I don't have enough time to e.g. go over all the issues.

@matthiasbeyer
Copy link
Member

Hi maintainers... I haven't seen any progress on this subject in the past few weeks. Thus, I'm pinging you all here. Can we please move forward? I'd take maintainership myself (possibly partly financed by my employer... I have to ask though, because we need this library for one of our tools), if nobody else steps up.

(Please don't add me right away, I'd rather be contributor than maintainer)

@matthiasbeyer
Copy link
Member

It seems that nobody feels responsible here.

Thus: I'd take maintainership myself to get this feature in I need. And I will, as soon as I have maintainer rights, go through all issues and close them if not applicable anymore or if the issuer does not respond within a reasonable time.


I need a feature to fix the issue from #163. I proposed a possible solution in #165 but I don't like the solution myself. I'd rather implement a cleaner solution, if I can find a way to do this.


@mehcode feel free to add me as maintainer, if you're okay with above points and especially with me closing issues and PRs if I see fit. I would give up maintainership (if you want me to, no actually I'd like to step down again as soon as possible) as soon as I've implemented my required feature in a nice way and worked through all issues and PRs at least once.

@matthiasbeyer
Copy link
Member

Still interested in getting this issue here solved.

@matthiasbeyer
Copy link
Member

I forked this now, as nobody responded for over two weeks. My fork is already released here: https://crates.io/crates/config-maint

Version 0.11.0 should be compatible to config in 0.10.*, so users should only need to update their Cargo.toml. I will continue development there and now start to include PRs from this repository in the config-maint codebase.

Feel free to submit your patches over there.

@matthiasbeyer
Copy link
Member

Just to make this clear: This fork did not happen in bad faith! I want to continue development on the original config-rs crate if possible. But as nobody responded, I will now continue maintaining my fork AND I will develop features there. If it happens that the two crates diverge too much for later backporting of things from config-rs-maint to config-rs, so be it.
I'd rather have progress and split than low-key maintenance without progress!

@up9cloud
Copy link
Contributor

@matthiasbeyer well, I think you could contact owner first. and here is the link for you:
https://discord.gg/uuruzJ7
you could just ping him (mehcode) on discord...
I saw him almost everyday answer questions on it.

@matthiasbeyer
Copy link
Member

I wrote an email at the beginning of this week, no response yet. All other maintainers did not respond either.

@up9cloud
Copy link
Contributor

well, what he said is ping him on discord.

And I wonder if there is an actual person contacting him on discord to ask to be the maintainer...

@mehcode
Copy link
Collaborator

mehcode commented Mar 14, 2021

@matthiasbeyer Added you as a maintainer here and on crates.io

@matthiasbeyer
Copy link
Member

Awesome, thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants