Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bitcoin dependency to 0.26 #156

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Bump bitcoin dependency to 0.26 #156

merged 1 commit into from
Jan 19, 2021

Conversation

romanz
Copy link
Contributor

@romanz romanz commented Jan 14, 2021

No description provided.

@romanz romanz changed the title Bump bitcoin to 0.26 Bump bitcoin dependency to 0.26 Jan 14, 2021
@sanket1729
Copy link
Member

utACK 16bd047.

sanket1729
sanket1729 reviewed Jan 14, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For byteorder related 1.29 fix: rust-bitcoin/rust-bitcoin@ef116ff

romanz added a commit to romanz/rust-bitcoincore-rpc that referenced this pull request Jan 15, 2021
@romanz
Add byteorder pinning for 1.29.0 compatibility
f0536d0 
Following rust-bitcoin#156 (review)
@romanz
Copy link
Contributor Author

romanz commented Jan 15, 2021

For byteorder related 1.29 fix: rust-bitcoin/rust-bitcoin@ef116ff

Thanks, fixed in f0536d0.

@sanket1729
Copy link
Member

Nice, utACk f0536d0

@romanz
Copy link
Contributor Author

romanz commented Jan 16, 2021

Tested with electrs bump branch:
https://github.com/romanz/electrs/runs/1709358609

sgeisler
sgeisler suggested changes Jan 17, 2021
View reviewed changes
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just squash the commits please so we get rid of the failing one? Might help with bisecting one day.

@romanz
Copy link
Contributor Author

romanz commented Jan 18, 2021

Thanks, squashed :)

sanket1729
sanket1729 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reACK 965f2e5

sgeisler
sgeisler approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 965f2e5

@shesek
Copy link
Contributor

shesek commented Jan 19, 2021

ACK 965f2e5, tested with bwt.

@sgeisler sgeisler merged commit db723c2 into rust-bitcoin:master Jan 19, 2021
@romanz
Copy link
Contributor Author

romanz commented Jan 19, 2021

Thanks!

@sgeisler
Copy link
Contributor

If you need a release you have to ask @stevenroose.

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanket1729 sanket1729 sanket1729 approved these changes

@sgeisler sgeisler sgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romanz @sanket1729 @shesek @sgeisler