From 5102e366e37f4a8356ee930d400dbadc9c8365d1 Mon Sep 17 00:00:00 2001 From: Andrew Morton Date: Thu, 2 Apr 2020 13:48:52 +1100 Subject: [PATCH] selftest-add-mremap_dontunmap-selftest-v7-checkpatch-fixes ERROR: Bad function definition - void mremap_dontunmap_partial_mapping_overwrite() should probably be void mremap_dontunmap_partial_mapping_overwrite(void) #34: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:228: +static void mremap_dontunmap_partial_mapping_overwrite() WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #68: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:251: + BUG_ON(source_mapping == MAP_FAILED, "mmap"); WARNING: line over 80 characters #109: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:264: + MREMAP_DONTUNMAP | MREMAP_MAYMOVE | MREMAP_FIXED, dest_mapping); WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #110: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:265: + BUG_ON(dest_mapping == MAP_FAILED, "mremap"); WARNING: line over 80 characters #111: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:266: + BUG_ON(dest_mapping != remapped_mapping, "expected to remap to dest_mapping"); WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #111: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:266: + BUG_ON(dest_mapping != remapped_mapping, "expected to remap to dest_mapping"); WARNING: line over 80 characters #120: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:272: + BUG_ON(check_region_contains_byte(dest_mapping, 5 * page_size, 'a') != 0, WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #120: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:272: + BUG_ON(check_region_contains_byte(dest_mapping, 5 * page_size, 'a') != 0, WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #133: FILE: tools/testing/selftests/vm/mremap_dontunmap.c:280: + BUG_ON(munmap(dest_mapping, 10 * page_size) == -1, total: 1 errors, 8 warnings, 126 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. ./patches/selftest-add-mremap_dontunmap-selftest-v7.patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Please run checkpatch prior to sending patches Cc: Brian Geffon Signed-off-by: Andrew Morton Signed-off-by: Stephen Rothwell --- tools/testing/selftests/vm/mremap_dontunmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/vm/mremap_dontunmap.c b/tools/testing/selftests/vm/mremap_dontunmap.c index 23240ee1e384c0..ee06cb0b9efbe0 100644 --- a/tools/testing/selftests/vm/mremap_dontunmap.c +++ b/tools/testing/selftests/vm/mremap_dontunmap.c @@ -225,7 +225,7 @@ static void mremap_dontunmap_partial_mapping() } // This test validates that we can remap over only a portion of a mapping. -static void mremap_dontunmap_partial_mapping_overwrite() +static void mremap_dontunmap_partial_mapping_overwrite(void) { /* * source mapping: