Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing indentation in run_proof_hint #4589

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Conversation

Robertorosmaninho
Copy link
Collaborator

We missed in the first implementation the indentation that keeps the temporary file opened. This PR fixed it.

Copy link
Contributor

@tothtamas28 tothtamas28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test / modify the existing test so that this issue is caught?

pyk/src/pyk/ktool/krun.py Outdated Show resolved Hide resolved
@Robertorosmaninho
Copy link
Collaborator Author

Can you add a test / modify the existing test so that this issue is caught?

I'm not sure if I can reproduce the error. Regardless of the indentation, the integration tests pass, the temporary file is created, and we're able to use it.

The error seems to happen only when calling the function from outside the project, in my example, calling it from the kevm. How to proceed?

@rv-jenkins rv-jenkins merged commit 9e12e63 into develop Aug 14, 2024
17 checks passed
@rv-jenkins rv-jenkins deleted the fix-identation-krun-hints branch August 14, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants