Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finch version e2e test failing consistently #527

Closed
ginglis13 opened this issue Aug 9, 2023 · 1 comment
Closed

finch version e2e test failing consistently #527

ginglis13 opened this issue Aug 9, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@ginglis13
Copy link
Contributor

Describe the bug
The version test Check finch version [It] Should print finch version information is failing consistently in CI since 1b3ad94.

This is odd because the values used to set the version appear to be fine:

https://github.com/runfinch/finch/actions/runs/5804355704/job/15733801308:

# This is Container e2e test, note no ".m" or ".modified"
go test -ldflags "-X github.com/runfinch/finch/pkg/version.Version=v0.7.0-18-g1b3ad94 -X github.com/runfinch/finch/pkg/version.GitCommit=1b3ad94f9477eb3f8d33cbea90880f78ca403ff7" -timeout 30m ./e2e/container -test.v -ginkgo.v --installed="false"

# This is VM e2e test, note no ".m" or ".modified"
go test -ldflags "-X github.com/runfinch/finch/pkg/version.Version=v0.7.0-18-g1b3ad94 -X github.com/runfinch/finch/pkg/version.GitCommit=1b3ad94f9477eb3f8d33cbea90880f78ca403ff7" -timeout 45m ./e2e/vm -test.v -ginkgo.v --installed="false"

Steps to reproduce

I haven't been able to reproduce locally.

Expected behavior

This test should pass.

Screenshots or logs

Additional context
Test defined here: https://github.com/runfinch/finch/blob/main/e2e/vm/version_test.go

@ginglis13
Copy link
Contributor Author

We haven't seen this issue since CI on the day this issue first presented itself. Working theory is concurrent builds interfered with each other in the GHA work directory, causing modification of finch builds. TODO is investigating and implementing a fix for our theory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants