Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate dependency upload actions #508

Closed
ginglis13 opened this issue Jul 28, 2023 · 1 comment
Closed

Deduplicate dependency upload actions #508

ginglis13 opened this issue Jul 28, 2023 · 1 comment
Assignees
@ginglis13

Comments

@ginglis13
Copy link
Contributor

What is the problem you're trying to solve?.

Finch currently pulls in the finch-core submodule, which includes similar if not the same dependency upgrade scripts.

Describe the feature you'd like

finch can remove its update-lima-dep.sh and run the same/similar script in its Sync Submodules action. That action pulls in finch-core, which has a script to do virtually the same thing https://github.com/runfinch/finch-core/blob/main/bin/update-deps.sh.

Additional context
Add any other context or screenshots about the feature request here.
@ginglis13 ginglis13 self-assigned this Jul 28, 2023
@ginglis13 ginglis13 mentioned this issue Jul 28, 2023
Closed
1 task
@ginglis13
Copy link
Contributor Author

closed by #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ginglis13 ginglis13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ginglis13