Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build-arg local env variable pass-through #187

Open
ningziwen opened this issue Jan 26, 2023 · 3 comments
Open

Build-arg local env variable pass-through #187

ningziwen opened this issue Jan 26, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ningziwen
Copy link
Member

What is the problem you're trying to solve?.
Similar to #35, build-arg in finch build is not supporting local env variable pass-through while Docker has this support.

Added draft failed e2e tests.

Describe the feature you'd like
Allow local env variable pass-through for build-arg.

@estesp
Copy link
Contributor

estesp commented Feb 13, 2023

Now that #158 is merged and we have the framework for dealing with this related to -e/--env, should we solve this in a similar way?

@ningziwen
Copy link
Member Author

@estesp Yes. Let me know if you want to collaborate it.

@weikequ weikequ added the enhancement New feature or request label Feb 16, 2023
@chews93319
Copy link
Contributor

As an additional update, the PR #1072 addressed cli parsing for other command names than build, but certainly clarifies why build does not utilize the helper functions for -e, --env, or --env-file arguments.
The incremental change of 1072 sets the stage for more command specific flag handling and inclusion of separate helper functions like the environment variable flags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants