From ccbaf9aa0ec02163b878e8f5026423bc4f9b2eb4 Mon Sep 17 00:00:00 2001 From: "Hsing-Yu (David) Chen" Date: Tue, 6 Dec 2022 03:56:49 +0800 Subject: [PATCH] docs: twin checks actually work but just confusing (#89) ## License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Hsing-Yu (David) Chen --- .github/workflows/ci-docs.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/ci-docs.yaml b/.github/workflows/ci-docs.yaml index f352e4338..1aa1303b3 100644 --- a/.github/workflows/ci-docs.yaml +++ b/.github/workflows/ci-docs.yaml @@ -1,6 +1,12 @@ # This file is created according to # https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/defining-the-mergeability-of-pull-requests/troubleshooting-required-status-checks#handling-skipped-but-required-checks # As a result, the set of jobs in this file should be equal to that in ci.yaml. +# +# Note that if a PR contains changes of both markdown files and non-markdown files, +# there'll be twins for each check (e.g., https://github.com/runfinch/finch/pull/88). +# However, due to GitHub's logic, even though the one from ci-docs.yaml passes, +# the one from ci.yaml still has to pass for the PR to be merged, +# so it functionally works, while it's visually confusing. name: CI on: push: