fix: Fix tests to match nerdctl 1.2.1 outputs #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar
changed the title
AnqiPang
reviewed
Mar 15, 2023
Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar
changed the title
davidhsingyuchen
approved these changes
Mar 15, 2023
AnqiPang
approved these changes
Mar 15, 2023
vsiravar
pushed a commit
that referenced
this pull request
Mar 16, 2023
🤖 I have created a release *beep* *boop* --- ## [0.6.2](v0.6.1...v0.6.2) (2023-03-16) ### Bug Fixes * Fix tests to match nerdctl 1.2.1 outputs ([#50](#50)) ([3d9b4f4](3d9b4f4)) ### Build System or External Dependencies * **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4 ([#41](#41)) ([a9476c1](a9476c1)) * **deps:** bump github.com/onsi/gomega from 1.27.1 to 1.27.2 ([#40](#40)) ([e8fc71a](e8fc71a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
After upgrading
nerdctldependency to 1.2.1, 7 e2e tests in finch fail due to failed assertions on output strings of finch commands.nerdctl images --quiet
Output before 1.2.1
Output in 1.2.1
nerdctl run/exec -u/--user
Output before 1.2.1
Output in 1.2.1
nerdctl run --group-add
Output before 1.2.1
Output in 1.2.1
Testing done:
Yes, locally.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.