From c18375ac1182ff117f30707718e800dfcef12e1e Mon Sep 17 00:00:00 2001 From: Monirul Islam Date: Tue, 11 Apr 2023 14:04:34 -0700 Subject: [PATCH] Removed flacky test case in compose down Signed-off-by: Monirul Islam --- tests/compose_down.go | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/tests/compose_down.go b/tests/compose_down.go index a875a3d..5e1e720 100644 --- a/tests/compose_down.go +++ b/tests/compose_down.go @@ -5,14 +5,12 @@ package tests import ( "fmt" - "os" - "time" - "github.com/onsi/ginkgo/v2" "github.com/onsi/gomega" "github.com/runfinch/common-tests/command" "github.com/runfinch/common-tests/ffs" "github.com/runfinch/common-tests/option" + "os" ) // ComposeDown tests functionality of `compose down` command. @@ -39,21 +37,6 @@ func ComposeDown(o *option.Option) { containerShouldNotExist(o, containerNames...) volumeShouldExist(o, "compose_data_volume") }) - - for _, volumes := range []string{"-v", "--volumes"} { - volumes := volumes - ginkgo.It(fmt.Sprintf("should stop compose services and delete volumes by specifying %s flag", volumes), func() { - volumes := volumes - // Wait 10 sec before calling compose down since compose down cmd sometimes fails to delete the volume - // due to concurrent access of the volume. - // For more details - https://github.com/runfinch/finch/issues/261 - time.Sleep(10 * time.Second) - - command.Run(o, "compose", "down", volumes, "--file", composeFilePath) - containerShouldNotExist(o, containerNames...) - volumeShouldNotExist(o, "compose_data_volume") - }) - } }) }