From 4973e9fa956b1339fa282d065576b417acfe2c52 Mon Sep 17 00:00:00 2001 From: Sam Berning <113054166+sam-berning@users.noreply.github.com> Date: Wed, 20 Sep 2023 17:34:27 -0700 Subject: [PATCH] fix: adds --all to the volume prune command to prune named volumes (#86) see https://github.com/containerd/nerdctl/commit/0844a51e43df1c7c445c3142e7729069c06812bd Issue #, if available: *Description of changes:* CI was failing in finch and finch-core due to a named volume not getting cleaned up after bumping nerdctl to v1.6.0. turns out there was a change in behavior for the `volume prune` command. *Testing done:* Ran common-tests with @vsiravar and the volume tests succeeded - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Sam Berning --- command/remove.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/command/remove.go b/command/remove.go index b71f8ff..2650316 100644 --- a/command/remove.go +++ b/command/remove.go @@ -5,7 +5,6 @@ package command import ( "github.com/onsi/ginkgo/v2" - "github.com/runfinch/common-tests/option" ) @@ -42,7 +41,7 @@ func RemoveVolumes(o *option.Option) { ginkgo.GinkgoWriter.Println("No volumes to be removed") return } - Run(o, "volume", "prune", "--force") + Run(o, "volume", "prune", "--force", "--all") } // RemoveImages removes all container images in the testing environment specified by o.