-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added new device + enhanced setup steps #82
base: master
Are you sure you want to change the base?
Conversation
domdorn
commented
May 13, 2021
- added DS1819+ to supported list.
- added steps to verify working installation
- create folders required to store artifacts + toolkit_tarballs
- added toolkit_tarballs volume mount to docker command
- added DS1819+ to supported list. - added steps to verify working installation - create folders required to store artifacts + toolkit_tarballs - added toolkit_tarballs volume mount to docker command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the additions!
@@ -190,6 +192,34 @@ them from here: https://sourceforge.net/projects/dsgpl/files/toolkit/DSM<DSM_VER | |||
(e.g. https://sourceforge.net/projects/dsgpl/files/toolkit/DSM6.2) | |||
|
|||
|
|||
Testing the installation | |||
------------------------ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Could you add a sentence that explicitly states that these commands should be run on the NAS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
README.rst
Outdated
@@ -52,6 +52,7 @@ DS1511+ x64 6.2 Yes | |||
DS1618+ denverton 6.2 Yes | |||
DS1817+ avoton 6.2 Yes | |||
DS1815+ avoton 6.2 Yes | |||
DS1819+ denverton 6.2 Yes (starting with WireGuard-1.0.20210424) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did it not work for older versions or did you not try it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it last time last summer and it did not work back then... package and kernel module compiled fine, but actual networking didn't. unfortunately, I didn't save the old version number before deploying the new package, so can't say for sure which version it was back then.
I could remove the "starting .." text, as anyway someone now coming to the page will try with the newest version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, remove that and I'll merge this 👍
- removed note about Wireguard version for DS1819+ - clarified testing procedure - explained toolkits_tarball volume enhancement