Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new device + enhanced setup steps #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

domdorn
Copy link

@domdorn domdorn commented May 13, 2021

  • added DS1819+ to supported list.
  • added steps to verify working installation
  • create folders required to store artifacts + toolkit_tarballs
  • added toolkit_tarballs volume mount to docker command

- added DS1819+ to supported list. 
- added steps to verify working installation
- create folders required to store artifacts + toolkit_tarballs
- added toolkit_tarballs volume mount to docker command
Copy link
Owner

@runfalk runfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the additions!

@@ -190,6 +192,34 @@ them from here: https://sourceforge.net/projects/dsgpl/files/toolkit/DSM<DSM_VER
(e.g. https://sourceforge.net/projects/dsgpl/files/toolkit/DSM6.2)


Testing the installation
------------------------
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Could you add a sentence that explicitly states that these commands should be run on the NAS?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.rst Outdated
@@ -52,6 +52,7 @@ DS1511+ x64 6.2 Yes
DS1618+ denverton 6.2 Yes
DS1817+ avoton 6.2 Yes
DS1815+ avoton 6.2 Yes
DS1819+ denverton 6.2 Yes (starting with WireGuard-1.0.20210424)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did it not work for older versions or did you not try it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it last time last summer and it did not work back then... package and kernel module compiled fine, but actual networking didn't. unfortunately, I didn't save the old version number before deploying the new package, so can't say for sure which version it was back then.
I could remove the "starting .." text, as anyway someone now coming to the page will try with the newest version.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, remove that and I'll merge this 👍

- removed note about Wireguard version for DS1819+
- clarified testing procedure
- explained toolkits_tarball volume enhancement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants